From 6c4d2ce6999f2ed02c19ebea28c539cff1433f03 Mon Sep 17 00:00:00 2001
From: Pau Rodriguez-Estivill <prodrigestivill@gmail.com>
Date: Sat, 20 Aug 2022 12:26:52 +0200
Subject: [PATCH] Remove unneded $? evaluation in a -e script

---
 backup.sh | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/backup.sh b/backup.sh
index 53aad44..16ad501 100755
--- a/backup.sh
+++ b/backup.sh
@@ -75,15 +75,12 @@ for DB in ${POSTGRES_DBS}; do
   WFILE="${BACKUP_DIR}/weekly/${WEEKLY_FILENAME}"
   MFILE="${BACKUP_DIR}/monthly/${MONTHY_FILENAME}"
   #Create dump
-  WEBHOOK=true
   if [ "${POSTGRES_CLUSTER}" = "TRUE" ]; then
     echo "Creating cluster dump of ${DB} database from ${POSTGRES_HOST}..."
     pg_dumpall -l "${DB}" ${POSTGRES_EXTRA_OPTS} | gzip > "${FILE}"
-    if [ $? - ne 0 ]; then WEBHOOK=false; fi
   else
     echo "Creating dump of ${DB} database from ${POSTGRES_HOST}..."
     pg_dump -d "${DB}" -f "${FILE}" ${POSTGRES_EXTRA_OPTS}
-    if [ $? - ne 0 ]; then WEBHOOK=false; fi
   fi
   #Copy (hardlink) for each entry
   if [ -d "${FILE}" ]; then
@@ -119,10 +116,10 @@ done
 
 echo "SQL backup created successfully"
 
-if [ "${WEBHOOK_URL}" != "**None**" -a ${WEBHOOK} ]; then
+if [ "${WEBHOOK_URL}" != "**None**" ]; then
   echo "Execute post-backup webhook call to ${WEBHOOK_URL}"
   curl --request POST \
-    --url ${WEBHOOK_URL} \
+    --url "${WEBHOOK_URL}" \
     --max-time 10 \
     --retry 5 \
     ${WEBHOOK_EXTRA_ARGS}