From 677381995237b8b7f39d1599dc982362114dc307 Mon Sep 17 00:00:00 2001
From: Pau Rodriguez-Estivill <prodrigestivill@gmail.com>
Date: Tue, 26 Mar 2019 16:06:32 +0100
Subject: [PATCH] Style update

---
 backup.sh | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/backup.sh b/backup.sh
index ed901f0..1101286 100755
--- a/backup.sh
+++ b/backup.sh
@@ -9,8 +9,8 @@ fi
 
 if [ "${POSTGRES_HOST}" = "**None**" ]; then
   if [ -n "${POSTGRES_PORT_5432_TCP_ADDR}" ]; then
-    POSTGRES_HOST=$POSTGRES_PORT_5432_TCP_ADDR
-    POSTGRES_PORT=$POSTGRES_PORT_5432_TCP_PORT
+    POSTGRES_HOST=${POSTGRES_PORT_5432_TCP_ADDR}
+    POSTGRES_PORT=${POSTGRES_PORT_5432_TCP_PORT}
   else
     echo "You need to set the POSTGRES_HOST environment variable."
     exit 1
@@ -37,7 +37,7 @@ else
   exit 1
 fi
 if [ "${POSTGRES_USER_FILE}" = "**None**" ]; then
-  export PGUSER="$POSTGRES_USER"
+  export PGUSER="${POSTGRES_USER}"
 elif [ -r "${POSTGRES_USER_FILE}" ]; then
   export PGUSER=$(cat "${POSTGRES_USER_FILE}")
 else
@@ -45,38 +45,38 @@ else
   exit 1
 fi
 if [ "${POSTGRES_PASSWORD_FILE}" = "**None**" ]; then
-  export PGPASSWORD="$POSTGRES_PASSWORD"
+  export PGPASSWORD="${POSTGRES_PASSWORD}"
 elif [ -r "${POSTGRES_PASSWORD_FILE}" ]; then
   export PGPASSWORD=$(cat "${POSTGRES_PASSWORD_FILE}")
 else
   echo "Missing POSTGRES_PASSWORD_FILE file."
   exit 1
 fi
-POSTGRES_HOST_OPTS="-h $POSTGRES_HOST -p $POSTGRES_PORT $POSTGRES_EXTRA_OPTS"
-KEEP_DAYS=$BACKUP_KEEP_DAYS
-KEEP_WEEKS=`expr $((($BACKUP_KEEP_WEEKS * 7) + 1))`
-KEEP_MONTHS=`expr $((($BACKUP_KEEP_MONTHS * 31) + 1))`
+POSTGRES_HOST_OPTS="-h ${POSTGRES_HOST} -p ${POSTGRES_PORT} ${POSTGRES_EXTRA_OPTS}"
+KEEP_DAYS=${BACKUP_KEEP_DAYS}
+KEEP_WEEKS=`expr $(((${BACKUP_KEEP_WEEKS} * 7) + 1))`
+KEEP_MONTHS=`expr $(((${BACKUP_KEEP_MONTHS} * 31) + 1))`
 
 #Initialize dirs
-mkdir -p "$BACKUP_DIR/daily/" "$BACKUP_DIR/weekly/" "$BACKUP_DIR/monthly/"
+mkdir -p "${BACKUP_DIR}/daily/" "${BACKUP_DIR}/weekly/" "${BACKUP_DIR}/monthly/"
 
 #Loop all databases
-for DB in $POSTGRES_DBS; do
+for DB in ${POSTGRES_DBS}; do
   #Initialize filename vers
-  DFILE="$BACKUP_DIR/daily/$DB-`date +%Y%m%d-%H%M%S`.sql.gz"
-  WFILE="$BACKUP_DIR/weekly/$DB-`date +%G%V`.sql.gz"
-  MFILE="$BACKUP_DIR/monthly/$DB-`date +%Y%m`.sql.gz"
+  DFILE="${BACKUP_DIR}/daily/${DB}-`date +%Y%m%d-%H%M%S`.sql.gz"
+  WFILE="${BACKUP_DIR}/weekly/${DB}-`date +%G%V`.sql.gz"
+  MFILE="${BACKUP_DIR}/monthly/${DB}-`date +%Y%m`.sql.gz"
   #Create dump
   echo "Creating dump of ${DB} database from ${POSTGRES_HOST}..."
-  pg_dump -f "$DFILE" $POSTGRES_HOST_OPTS $DB
+  pg_dump -f "${DFILE}" ${POSTGRES_HOST_OPTS} ${DB}
   #Copy (hardlink) for each entry
-  ln -vf "$DFILE" "$WFILE"
-  ln -vf "$DFILE" "$MFILE"
+  ln -vf "${DFILE}" "${WFILE}"
+  ln -vf "${DFILE}" "${MFILE}"
   #Clean old files
   echo "Cleaning older than ${KEEP_DAYS} days for ${DB} database from ${POSTGRES_HOST}..."
-  find "$BACKUP_DIR/daily" -maxdepth 1 -mtime +$KEEP_DAYS -name "$DB-*.sql*" -exec rm -rf '{}' ';'
-  find "$BACKUP_DIR/weekly" -maxdepth 1 -mtime +$KEEP_WEEKS -name "$DB-*.sql*" -exec rm -rf '{}' ';'
-  find "$BACKUP_DIR/monthly" -maxdepth 1 -mtime +$KEEP_MONTHS -name "$DB-*.sql*" -exec rm -rf '{}' ';'
+  find "${BACKUP_DIR}/daily" -maxdepth 1 -mtime +${KEEP_DAYS} -name "${DB}-*.sql*" -exec rm -rf '{}' ';'
+  find "${BACKUP_DIR}/weekly" -maxdepth 1 -mtime +${KEEP_WEEKS} -name "${DB}-*.sql*" -exec rm -rf '{}' ';'
+  find "${BACKUP_DIR}/monthly" -maxdepth 1 -mtime +${KEEP_MONTHS} -name "${DB}-*.sql*" -exec rm -rf '{}' ';'
 done
 
 echo "SQL backup uploaded successfully"